summaryrefslogtreecommitdiffstats
path: root/mozilla-817533.patch
diff options
context:
space:
mode:
Diffstat (limited to 'mozilla-817533.patch')
-rw-r--r--mozilla-817533.patch32
1 files changed, 32 insertions, 0 deletions
diff --git a/mozilla-817533.patch b/mozilla-817533.patch
new file mode 100644
index 0000000..11d1bb7
--- /dev/null
+++ b/mozilla-817533.patch
@@ -0,0 +1,32 @@
+# HG changeset patch
+# Parent d09a5a5666baa44c817a4e1e463ef62eae0a1105
+# User Patrick McManus <mcmanus@ducksong.com>
+bug 817533 - failed system proxy lookups should not fallback to manual configs r?jduell
+
+diff --git a/netwerk/base/src/nsProtocolProxyService.cpp b/netwerk/base/src/nsProtocolProxyService.cpp
+--- a/netwerk/base/src/nsProtocolProxyService.cpp
++++ b/netwerk/base/src/nsProtocolProxyService.cpp
+@@ -1553,17 +1553,22 @@ nsProtocolProxyService::Resolve_Internal
+
+ // Proxy auto config magic...
+ if (mProxyConfig == PROXYCONFIG_PAC || mProxyConfig == PROXYCONFIG_WPAD) {
+ // Do not query PAC now.
+ *usePACThread = true;
+ return NS_OK;
+ }
+
+- // proxy info values
++ // If we aren't in manual proxy configuration mode then we don't
++ // want to honor any manual specific prefs that might be still set
++ if (mProxyConfig != PROXYCONFIG_MANUAL)
++ return NS_OK;
++
++ // proxy info values for manual configuration mode
+ const char *type = nullptr;
+ const nsACString *host = nullptr;
+ int32_t port = -1;
+
+ uint32_t proxyFlags = 0;
+
+ if ((flags & RESOLVE_PREFER_SOCKS_PROXY) &&
+ !mSOCKSProxyHost.IsEmpty() && mSOCKSProxyPort > 0) {