From 9f7298ac633f610af96b0b915e49596bb5520aeb Mon Sep 17 00:00:00 2001
From: Remi Collet <remi@remirepo.net>
Date: Fri, 10 Nov 2023 10:32:24 +0100
Subject: don't rely on rpmfiSetFX return value

---
 rpminfo.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'rpminfo.c')

diff --git a/rpminfo.c b/rpminfo.c
index 13d4293..08ba780 100644
--- a/rpminfo.c
+++ b/rpminfo.c
@@ -857,8 +857,9 @@ PHP_FUNCTION(rpmgetsymlink)
 	fi = rpmfiNewArchiveReader(gzdi, files, RPMFI_ITER_READ_ARCHIVE);
 
 	rc = rpmfiFindFN(fi, name);
+	rpmfiSetFX(fi, rc); /* return value not reliable on librpm < 4.17 */
 	if (rc < 0
-        || rpmfiSetFX(fi, rc) < 0
+        || rpmfiFX(fi) != rc
 		|| (link = rpmfiFLink(fi)) == NULL) {
 		RETVAL_NULL();
 	} else {
-- 
cgit