summaryrefslogtreecommitdiffstats
path: root/689a0a89e03786d02718f96db269fc04b5d24d65.patch
blob: d1806e98ae00db61194502570372a99c827392ea (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
From 689a0a89e03786d02718f96db269fc04b5d24d65 Mon Sep 17 00:00:00 2001
From: Jan Schneider <jan@horde.org>
Date: Mon, 13 Feb 2017 14:57:35 +0100
Subject: [PATCH] Don't use each().

For modern PHP versions there is no improved performance or memory usage compared to foreach() anymore. Beside that it's deprecated in PHP 7.2.
---
 lib/Horde/History/Log.php | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/Horde/History/Log.php b/lib/Horde/History/Log.php
index b60389f..4083fa7 100644
--- a/lib/Horde/History/Log.php
+++ b/lib/Horde/History/Log.php
@@ -36,8 +36,7 @@ public function __construct($uid, $data = array())
             return;
         }
 
-        reset($data);
-        while (list(,$row) = each($data)) {
+        foreach ($data as $row) {
             $history = array(
                 'action' => $row['history_action'],
                 'desc' => $row['history_desc'],