From 65c4dd7dd6137c9942393db6475d697916405e1c Mon Sep 17 00:00:00 2001 From: Remi Collet Date: Tue, 19 Dec 2017 10:56:41 +0100 Subject: Fix FTBFS from Koschei, add upstream patch for PHP 7.2 --- 689a0a89e03786d02718f96db269fc04b5d24d65.patch | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 689a0a89e03786d02718f96db269fc04b5d24d65.patch (limited to '689a0a89e03786d02718f96db269fc04b5d24d65.patch') diff --git a/689a0a89e03786d02718f96db269fc04b5d24d65.patch b/689a0a89e03786d02718f96db269fc04b5d24d65.patch new file mode 100644 index 0000000..d1806e9 --- /dev/null +++ b/689a0a89e03786d02718f96db269fc04b5d24d65.patch @@ -0,0 +1,24 @@ +From 689a0a89e03786d02718f96db269fc04b5d24d65 Mon Sep 17 00:00:00 2001 +From: Jan Schneider +Date: Mon, 13 Feb 2017 14:57:35 +0100 +Subject: [PATCH] Don't use each(). + +For modern PHP versions there is no improved performance or memory usage compared to foreach() anymore. Beside that it's deprecated in PHP 7.2. +--- + lib/Horde/History/Log.php | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +diff --git a/lib/Horde/History/Log.php b/lib/Horde/History/Log.php +index b60389f..4083fa7 100644 +--- a/lib/Horde/History/Log.php ++++ b/lib/Horde/History/Log.php +@@ -36,8 +36,7 @@ public function __construct($uid, $data = array()) + return; + } + +- reset($data); +- while (list(,$row) = each($data)) { ++ foreach ($data as $row) { + $history = array( + 'action' => $row['history_action'], + 'desc' => $row['history_desc'], -- cgit