From bc593af1310990d58ed0ec3327e2eef1d2088057 Mon Sep 17 00:00:00 2001 From: Remi Collet Date: Tue, 3 Jul 2018 07:57:46 +0200 Subject: add upstream patch to fix SQL injection CVE-2018-13049 --- 3391f10eacec880aebcd4297bd2658ae13473947.patch | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 3391f10eacec880aebcd4297bd2658ae13473947.patch (limited to '3391f10eacec880aebcd4297bd2658ae13473947.patch') diff --git a/3391f10eacec880aebcd4297bd2658ae13473947.patch b/3391f10eacec880aebcd4297bd2658ae13473947.patch new file mode 100644 index 0000000..85ab682 --- /dev/null +++ b/3391f10eacec880aebcd4297bd2658ae13473947.patch @@ -0,0 +1,22 @@ +From 3391f10eacec880aebcd4297bd2658ae13473947 Mon Sep 17 00:00:00 2001 +From: Johan Cwiklinski +Date: Mon, 2 Jul 2018 08:12:32 +0200 +Subject: [PATCH] Cast limits to integer; fixes #4270 + +--- + inc/search.class.php | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/inc/search.class.php b/inc/search.class.php +index 79c32856bd..b6f684be26 100644 +--- a/inc/search.class.php ++++ b/inc/search.class.php +@@ -890,7 +890,7 @@ static function constructSQL(array &$data) { + $numrows = 0; + //No search : count number of items using a simple count(ID) request and LIMIT search + if ($data['search']['no_search']) { +- $LIMIT = " LIMIT ".$data['search']['start'].", ".$data['search']['list_limit']; ++ $LIMIT = " LIMIT ".(int)$data['search']['start'].", ".(int)$data['search']['list_limit']; + + // Force group by for all the type -> need to count only on table ID + if (!isset($searchopt[1]['forcegroupby'])) { -- cgit